Update sample request links to use sandbox #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianashk
reviewed
May 31, 2017
search.md
Outdated
| @@ -9,7 +9,7 @@ Making the leap from text to coordinates is an intricate and challenging process | |||
| All Mapzen Search requests share the same format: | |||
|
|
|||
| ``` | |||
| https://search.mapzen.com/v1/search?text=London&api_key=mapzen-xxxxxx | |||
| https://search.mapzen.com/v1/search?text=London&api_key=your-mapzen-api-key | |||
| \___/ \_______________/\__/\_____/\__________/\___________________/ | |||
There was a problem hiding this comment.
should we extend the last line to come to the end of the api key placeholder text for consistency?
dianashk
approved these changes
May 31, 2017
|
@rmglennon, you mentioned some results being different, which ones in particular? I'd like to have a look at them to make sure nothing is broken. :) Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes mostly update the links to use the (awesome!) sandbox site, compared to the URL to the raw JSON response. This is done to make sure the links work following the requirement to use an API key with all requests.
I made a few other minor edits as I went through, such as typos, markdown formatting (there should be a space between a # and the text in a heading and a line break after a heading), and style to change mapzen-xxxxxx to the preferred variable of
your-mapzen-api-key.In some cases, these queries give different results now than what we have documented. I have noted those places and we can review later...this is slightly more than a find and replace exercise, but does not include significant content updates.